Improve module name and make use of namespace option in CMake for modules#362
Merged
garyscavone merged 3 commits intothestk:masterfrom Nov 1, 2025
mikomikotaishi:master
Merged
Improve module name and make use of namespace option in CMake for modules#362garyscavone merged 3 commits intothestk:masterfrom mikomikotaishi:master
garyscavone merged 3 commits intothestk:masterfrom
mikomikotaishi:master
Conversation
mikomikotaishi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes use of the CMake option
RTMIDI_USE_NAMESPACEto allow the user to force the namespacert::midi. It also updates the namespace and module to the formrt.midi(to emphasise the relationship between RtMidi and RtAudio by sharing thertnamespace).