Show Specific Error Messages in New User View#76
Open
americanhanko wants to merge 2 commits into
Open
Conversation
americanhanko
changed the title
Comment on lines
+8
to
+9
| * Ruby 2.7.3 | ||
| * Yarn with Node.js v14 |
Owner
There was a problem hiding this comment.
Would you mind pulling these out into a separate PR?
Comment on lines
+6
to
+8
| <% @user.errors.full_messages.each do |error_message| %> | ||
| <%= error_message %> | ||
| <% end %> |
Owner
There was a problem hiding this comment.
This is great, but I wonder if we want to exclude the error message that says the email address is already taken. It feels like it might be responsible not to expose that information to anyone trying to use the sign up form. I think there are a few ways we could do this:
- We can pair the errors with their respective fields (e.g., errors for first name next to the first name field and so on).
- We might be able to filter out that error in particular.
- We can stick to the original generic error, and modify it a bit:
All fields are required. If you're having trouble, make sure you don't already have an account with the same email. Reset your password here
And we could link them to the password reset form in that message.
I'm partial to 1 or 2, but 3 is super easy. Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
ActiveRecordin the new users viewWhy
Previously, any error encountered during sign-up resulted in "Please fill out all fields". Now, users will receive specific feedback about what is wrong with their field entry.