Add JavaScript linter support and update requirements - #3
Open
vidhiverma123 wants to merge 1 commit into
Open
Conversation
thesujai
reviewed
Oct 18, 2024
Owner
There was a problem hiding this comment.
There are few things to consider to take this in the right direction:
- If js is added as linters then the eslints and other js specific linters should be added with npm. So pip install lintmate[javascript] should actually install eslint and other linters using npm. Currently you are assuming pip will install eslint, which is not the case
- The format_javascript is okay, but you should also add changes in linter-cli/linters/
- You should also update the cli.lint_cli() function.
I would suggest you to first use this package and to understand it start reading code from cli,py
Owner
The users of the library should just be able to do pip install lintmate[javascript]. The above command should run from our code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request introduces support for linting JavaScript (.js) files in the lintmate CLI tool. It includes:
setup.pyfile to include ESLint as a dependency.Importance of Changes
Adding support for JavaScript linting expands the functionality of lintmate, allowing developers to maintain code quality across multiple languages. This enhancement facilitates the use of lintmate in JavaScript projects, making it a more versatile tool for developers.
Testing Instructions
To test the changes: