introducing wave forcing for sediment transport and tidal inlet test case #409
Draft
seimurss wants to merge 3 commits intothetisproject:mainfrom
Draft
introducing wave forcing for sediment transport and tidal inlet test case #409seimurss wants to merge 3 commits intothetisproject:mainfrom
seimurss wants to merge 3 commits intothetisproject:mainfrom
Conversation
…2) tidal inlet test case in examples. 3) introduction of wave_forcing option for sediments and van Rijn bedload formulation.
pull thetisproject repo
…ad of a soft linke. removed comments from unnecessary sediment_model.py
Contributor
|
This looks pretty good already! My main feedback/questions at this moment are:
Assuming these can be addressed, have another look through the diff yourself and make sure there's no changes you didn't mean to include (in particular don't include commented out code). Then if you remove the draft status, I would be happy to go through it in more detail line-by-line, with some nitty-gritty things (none of it really interesting). At a first glance I couldn't see any major issues implementation wise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave forcing was introduced for the radiation stresses following fragkouan/thetis_wci (Fragkou et al., 2024) and similarly, other fields, such as Hs, Ub, T, wave dir, and freq. were introduced and adapted in sediment transport model, albeit only orbital velocities are accounted for in bottom stresses computation.
Tidal inlet test case (Warner et al., 2008) was developed to test the seabed evolution in the presence of waves and tides.