fix-fetching-userids-offlineconversions-accounting-for-numpy-ndarray#53
Merged
adithyasamavedhi-ttd merged 1 commit intoJun 12, 2026
Merged
Conversation
adithyasamavedhi-ttd
force-pushed
the
fix-fetching-userids-offlineconversions
branch
from
e912a87 to
04d267f
Compare
adithyasamavedhi-ttd
force-pushed
the
fix-fetching-userids-offlineconversions
branch
from
04d267f to
c75cc23
Compare
legrigonis
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
MapInPandas, the offline conversionuser_idsarrive a numpy.ndarray instead of a list, this PR changes the checks used in batch processing to be unambiguous to both list/ numpy ndarrays.Tests