Open
Conversation
|
PR build artifacts are ready:
These artifacts are temporary and are deleted automatically when the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances SVG import and rendering by improving how layer and path stroke colors are detected, inherited, and rendered. It adds robust support for Inkscape layer markers, ensures stroke colors are captured from both layers and paths (including inherited styles), and updates the rendering logic to use these colors for more accurate visual output. The changes also introduce new tests to cover these behaviors.
Note: Colours are overridden by the apps own layer colours:

SVG Import and Layer Detection Improvements:
inkscape:groupmode="layer"attribute, allowing SVGs created in Inkscape to be properly imported with their logical layers recognized. [1] [2]Stroke Color Inheritance and Normalization:
SvgPathandSvgLayertypes to store the resolvedsourceStrokeColorfor use in rendering. [1] [2]Rendering Logic Enhancements:
PlotCanvasto bucket outlines and hatches by color, and to use the correct stroke colors for each path or layer, including selection highlighting. [1] [2] [3] [4] [5]Testing and Validation:
These changes result in more accurate and visually faithful SVG imports, especially for files created in Inkscape or using complex group structures.