Open
Conversation
|
PR build artifacts are ready:
These artifacts are temporary and are deleted automatically when the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new "round sharp corners" feature to the G-code export workflow, allowing users to automatically smooth sharp polyline corners with arcs of configurable angle and radius. The implementation affects the user interface, data models, and the G-code generation logic. Additionally, it introduces infrastructure for re-clipping hatch lines against rounded boundaries and updates related types and state management.
New round-corner smoothing feature:
GcodeOptionsDialog.tsx. [1] [2] [3] [4]GcodePrefs,GcodeOptions) and the toolbar to support the new round-corner parameters. [1] [2] [3]G-code engine and SVG worker enhancements:
gcodeEngine.tsfor rounding polyline corners (roundSubpathCorners) and for re-clipping hatch lines against rounded polygons (clipSegmentToPolygon).Data model and state management updates:
VectorObjecttype to include an optionalhatchParentIdproperty for hatch-fill lines, enabling correct association and re-clipping during G-code generation.canvasStoreto sethatchParentIdfor generated hatch lines. [1] [2] [3]