Merged
Conversation
Member
Author
|
Relates to issue #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves mouse interaction handling on the canvas by making right-click (mouse button 2) consistently initiate panning, in addition to the existing middle-click (button 1) support. It also ensures that only primary mouse button interactions trigger object manipulation (drag, scale, rotate, group bounding box handles), preventing accidental gestures with right or middle clicks. The tests are updated to cover these behaviors.
Mouse interaction and event handling improvements:
useCanvasInteractionHandlersto allow both right-click (button 2) and middle-click (button 1) to start panning the canvas, and to prevent default browser behavior for these buttons.isNonPrimaryButtonutility in several hooks (useObjectDrag,useObjectScaleRotate,useGroupOBB) to ensure that only primary button (button 0, usually left-click) can trigger object drag, scale, rotate, or group bounding box handle actions. [1] [2] [3] [4] [5] [6] [7]Testing enhancements:
PlotCanvas.test.tsxto verify that right-click can pan the canvas, and that right-clicking on an import pans the canvas without moving the import itself. Also, refactored theResizeObserversetup utility for reuse and removed duplicate code. [1] [2] [3]