Conversation
cryptoki 0.11 fixes UB when using CKA_ALLOWED_MECHANISMS with softhsm and also removes unmaintained paste crate in 0.12. Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Robot Results
|
| # TODO: remove once fix is upstreamed to libloading | ||
| [patch.crates-io] | ||
| libloading = { git = "https://github.com/Bravo555/rust_libloading.git", branch = "0.8.8" } | ||
| libloading = { git = "https://github.com/Bravo555/rust_libloading.git", branch = "0.8.9" } |
There was a problem hiding this comment.
Okay. This is to remove dl linker flag under musl: nagisa/rust_libloading@master...Bravo555:rust_libloading:0.8.9
What's the plan to get rid of this patch?
There was a problem hiding this comment.
Once I manage to reproduce the error message that the change is fixing, so I can include it in the PR, I will create a PR to the libloading repository.
I was neglecting to create the PR because I don't really have a good idea of how our build process for musl works such that this error appears, so I can't reproduce the error without actually using our CI pipelline. For this reason, I'm not able to produce a minimal example of this problem showing that this change "fixes" it, or even really describe the problem in detail at all. All i know is that it works for us, but I'm not completely sure that this change is "correct" for the upstream repository, so I was worrying that I won't be able to provide enough context for the maintainer describing why the change is correct.
Nevertheless, I've been putting it off for too long so I will create PR including a best effort description and the error message. If maintainer asks for more details about building for musl, I'll ask @reubenmiller for help.
There was a problem hiding this comment.
After a bit more research it turns out that perhaps patching libloading was not necessary and we should make the changes in our build process instead: nagisa/rust_libloading#195 (comment)
Proposed changes
cryptoki 0.11 fixes UB when using
CKA_ALLOWED_MECHANISMSwith softhsm and also removes unmaintained paste crate in 0.12.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments