chore: remove libloading patch#3973
Merged
Bravo555 merged 2 commits intothin-edge:mainfrom Feb 17, 2026
Merged
Conversation
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Bravo555
force-pushed
the
chore/remove-libloading-patch
branch
from
027c9ae to
879192e
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
force-pushed
the
chore/remove-libloading-patch
branch
from
66737e5 to
5dbf74f
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Contributor
Robot Results
|
Bravo555
force-pushed
the
chore/remove-libloading-patch
branch
from
5dbf74f to
324b0c7
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
requested review from
albinsuresh,
didier-wenzek,
jarhodes314,
reubenmiller and
rina23q
as code owners
reubenmiller
added
refactoring
reubenmiller
approved these changes
Feb 13, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Bravo555
force-pushed
the
chore/remove-libloading-patch
branch
from
324b0c7 to
9addc63
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Provide --sysroot argument to rust-lld linker when compiling with musl, such that crates that wish to link with libraries like libdl (which are empty stubs but provided by musl) are able to do so. This change is made to make crates that link to libraries other than just libc, like libdl, build without issues. These libraries are provided by musl libc, so we should be able to link with them properly. Additional details in a [github comment][1]. [1]: nagisa/rust_libloading#195 (comment) How the linker gets invoked can be observed by setting RUSTFLAGS="-Clink-arg=-v -Wlinker-messages" Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Bravo555
force-pushed
the
chore/remove-libloading-patch
branch
from
9addc63 to
695e60b
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove libloading patch, which was used to make the crate build with our
mk/cargo.sh, which changed some compilation settings to allow some other crates to be built for some targets. The build settings are changed to provide the library path torust-lldlinker, making the patch no longer necessary.More details: nagisa/rust_libloading#195 (comment)
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments