Implement Node.traverse() to allow custom graph traversals.#103
Open
dkushner wants to merge 1 commit intothingdom:masterfrom
Open
Implement Node.traverse() to allow custom graph traversals.#103dkushner wants to merge 1 commit intothingdom:masterfrom
dkushner wants to merge 1 commit intothingdom:masterfrom
Conversation
Member
|
Thanks for submitting this, @dkushner! Just to clarify, test coverage was added, right? Is there any more you plan to add to this PR? |
Member
|
Btw, you're correct that https://github.com/thingdom/node-neo4j/blob/1.1.0/lib/util.coffee#L151-L152 This is because Cypher's |
Member
|
Sorry for the delay, @dkushner. The tests fail locally for me, do they fail for you too? If you merge the latest master into your branch (or if you know git well, rebase your branch to the latest master) and re-push, Travis CI is properly configured now, so we can see whether they pass there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Node.traverse() method, satisfying #102. Total test coverage is forthcoming and it currently does not check for the 'fullpath' return type since that doesn't seem to be supported anywhere else in the API.