Require callback on commit#186
Open
broder wants to merge 90 commits intothingdom:v2from
broder:Require_callback_on_commit
Open
Require callback on commit#186broder wants to merge 90 commits intothingdom:v2from broder:Require_callback_on_commit
broder wants to merge 90 commits intothingdom:v2from
broder:Require_callback_on_commit
Conversation
No need to traverse the response body looking for REST format nodes & relationships when there won’t be any.
Clearer and more precise name.
We no longer have such slow tests. Woohoo!
Unfortunately it seems broken at the moment: coffeedoc/codo#194 coffeedoc/codo#195 And the auto-webhook site is down too: coffeedoc/coffeedoc.info#9 Given these issues, going to just write docs manually.
To pave the way for an Index class.
For Streamline 1.0 / Babel / ES6.
This reverts commit 42b73f4f618cef89ebc17710b656608a2f5bdcdf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully solves: #170 by ensuring that a callback is passed (rather than making the callback optional)