Skip to content

fix(views): call navigation callbacks before async ops to prevent unmounting #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emypeeler merged 1 commit into from
Feb 28, 2026
Merged

fix(views): call navigation callbacks before async ops to prevent unmounting #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions views/ProductView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,25 +77,27 @@ const ProductView = ({
}

const handleIDontNeedIt = async () => {
onShowIDontNeedIt(product)

if (product) {
try {
await ProductActionManager.dontNeedIt(product)
} catch (error) {
console.error("[ProductView] Failed to execute dontNeedIt:", error)
}
}
onShowIDontNeedIt(product)
}

const handleINeedIt = async () => {
onShowINeedIt()

if (product) {
try {
await ProductActionManager.needIt(product)
} catch (error) {
console.error("[ProductView] Failed to execute needIt:", error)
}
}
onShowINeedIt()
}

const handleCloseClick = () => {
Expand Down