Open
Conversation
ch4mpy
force-pushed
the
unit-test-boot-3
branch
from
b302cee to
29d6680
Compare
ch4mpy
force-pushed
the
unit-test-boot-3
branch
from
29d6680 to
95d11bf
Compare
ch4mpy
force-pushed
the
unit-test-boot-3
branch
from
95d11bf to
015194d
Compare
Contributor
Author
|
@thomasdarimont I added a commit to:
|
thomasdarimont
force-pushed
the
main
branch
6 times, most recently
from
b261678 to
cbc4cee
Compare
thomasdarimont
force-pushed
the
main
branch
from
9407a94 to
caaae72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some unit-tests for access-control rules on the only endpoint of the application:
/api/users/me.This tests enlight that the Require the role "ACCESS" for all api paths is not implemented (probably a regression when moving from
hasAuthority()toaccess()). This perfectly illustrates the value of such tests.As those access control rules are very simple, this is quickly tested.
As most production security implementations involve at some access-rules based on authorities, it could be worth adding some RBAC to this application.