Skip to content

fix: pin .claude markdown to LF so the pr-review parity gate compares equal bytes #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasluizon wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix: pin .claude markdown to LF so the pr-review parity gate compares equal bytes #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
src/Orbit.Api/openapi.json text eol=lf
# Every markdown file under .claude/ checks out LF here, exactly as it does in
# orbit-ui-mobile. The pr-review skill is single-sourced in the UI repo and mirrored
# into this one, and tools/launch-worker.mjs refuses an API review when the two copies
# disagree. Without this line core.autocrlf=true materialized the identical committed
# blob as CRLF here and LF there, +230 bytes on SKILL.md and +289 on rubric.md, so the
# gate compared different bytes for the same content and stood 76 tickets down on
# 2026-08-08. `git status` stayed clean in both repos, which is why nothing looked wrong.
.claude/**/*.md text eol=lf

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rematerialize the unchanged Markdown files

When this commit is pulled into an existing core.autocrlf=true checkout whose .claude Markdown files already contain CRLF, Git updates .gitattributes but leaves these unchanged blobs untouched, so the launcher continues hashing the 13,618-byte CRLF SKILL.md and the parity gate remains blocked. Reproducing a checkout from the parent to this commit retained all 230 CR bytes despite git check-attr reporting eol: lf; this rollout therefore needs an explicit worktree refresh or the blob-based launcher change to land simultaneously.

Useful? React with 👍 / 👎.

.claude/skills/**/*.mjs text eol=lf
tools/*.mjs text eol=lf
architecture.json text eol=lf
Expand Down
Loading