Skip to content

Signed (negative) double factorial #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berquist wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Signed (negative) double factorial #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0035f53
Initial incorrect implementation of signed (negative) double factorial
berquist Nov 30, 2019
40681e2
Correct implementation of signed (negative) double factorial
berquist Feb 23, 2020
30431fa
Make sure GSL is installed for Travis
berquist Feb 23, 2020
98e7155
Remove unnecessary extern crates
berquist Feb 23, 2020
7d31ec7
Fix tests
berquist Feb 23, 2020
ed704a2
Simplify f64 conversion
berquist Feb 23, 2020
42a9e55
SignedDoubleFactorial -> FloatDoubleFactorial
berquist Feb 24, 2020
7ebe006
Fixed a logic bug in base case for double factorial
berquist May 3, 2020
7cc2523
Test GSL and no features in Travis
berquist May 3, 2020
1db6f54
Benchmarking says GSL is an order of magnitude slower than pure version
berquist May 3, 2020
905eed9
No need for negative_odd_double_factorial anymore
berquist May 3, 2020
5c10759
No need for features or GSL in Travis
berquist May 3, 2020
9196530
Disallow -1 and -3 double factorial for integers
berquist May 3, 2020
91a9f55
Remove stale trait bounds
berquist May 4, 2020
fa3d34a
Documentation
berquist May 4, 2020
361a97a
Add supertraits for factorial and double factorial
berquist May 4, 2020
7ce1bdc
Ensure that negative signed factorial is undefined
berquist Oct 8, 2020
fc9c672
Remove leftover change from GSL modifications
berquist Dec 26, 2021
73a39f0
Remove pointless supertraits from 361a97a
berquist Dec 26, 2021
0500498
Double factorial with fractional part is undefined
berquist Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ travis-ci = { repository = "thomwiggers/factorial" }
maintenance = { status = "passively-maintained" }

[dev-dependencies]
approx = "0.3"
num-bigint = "0.3"

[dependencies]
Expand Down
Loading