docs: correct outbound fee multiplier from 2.5x to 3x in FAQ#109
Open
familiarcow wants to merge 1 commit intothorchain:masterfrom
Open
docs: correct outbound fee multiplier from 2.5x to 3x in FAQ#109familiarcow wants to merge 1 commit intothorchain:masterfrom
familiarcow wants to merge 1 commit intothorchain:masterfrom
Conversation
The FAQ stated the outbound fee multiplier is "up to 2.5x" but the actual MaxOutboundFeeMultiplierBasisPoints constant is 30,000 (3x). Verified against thornode commit: 83dc71a3d Source: thornode/constants/constants_v1.go:L103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the outbound fee multiplier value in the FAQ from "up to 2.5x" to "up to 3x".
Source of Truth
thornode/constants/constants_v1.goThe
MaxOutboundFeeMultiplierBasisPointsconstant is set to 30,000 (3x), not 25,000 (2.5x).Changes
Test Plan