docs: update outbound throttling to reference Mimir parameters#113
Open
familiarcow wants to merge 2 commits intothorchain:masterfrom
Open
docs: update outbound throttling to reference Mimir parameters#113familiarcow wants to merge 2 commits intothorchain:masterfrom
familiarcow wants to merge 2 commits intothorchain:masterfrom
Conversation
The security documentation stated the max outbound delay is 720 blocks (~1 hour) but the TxOutDelayMax constant is 17,280 blocks (~1 day). Verified against thornode commit: 83dc71a3d Source: thornode/constants/constants_v1.go:L78
The security documentation had hardcoded values that are now outdated: - "1000 RUNE worth" per block → now controlled by MinTxOutVolumeThreshold - "720 blocks (approx one hour)" → incorrect; delay controlled by MaxTxOutOffset and TxOutDelayMax Updated to reference the Mimir parameter names since these values are configurable and have changed from the original documentation. Current live Mimir values (as of verification): - MinTxOutVolumeThreshold: 20,000 RUNE - MaxTxOutOffset: 200 blocks (~20 minutes) - TxOutDelayMax: 17,280 blocks (code default) Verified against thornode commit: 83dc71a3d Source: thornode/x/thorchain/manager_txout_current.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the outbound transaction throttling documentation to reference Mimir parameter names instead of hardcoded values that have changed.
Issues Fixed
MinTxOutVolumeThresholdis now 20,000 RUNEMaxTxOutOffset: Caps initial calculated delay (currently 200 blocks, ~20 mins)TxOutDelayMax: Search limit for finding available slots if blocks are fullSource of Truth
thornode/x/thorchain/manager_txout_current.go:L1082-1176Changes
MinTxOutVolumeThresholdMaxTxOutOffsetandTxOutDelayMaxinteractionTest Plan