feat(SGE): Web Rebase to 10.0.x #441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or students on the homepage
…on and UI updates
…ant extension form This commit adds the Student Search and Select feature to the Staff Grant Extension form, enhancing the form's usability by allowing staff to search for individual students and select multiple students for bulk extension grants. This update integrates directly with the existing extension form backend, improving the overall user experience for staff handling large classes. Changes include: - Added student search input for filtering student lists. - Implemented multi-student selection support for bulk operations. - Improved UI components for efficient student selection. - Integrated with the existing form backend for seamless data flow. References: - Related to JoeMacl's Grant Extension Form PR thoth-tech#330 - Addresses requirements for bulk extension management.
- Create new Staff Grant Extension page with two-column layout - Left panel: Task list using FUnitTaskListComponent - Right panel: Embedded grant extension form (copied from admin modals) - Form is disabled until a task is selected - Form resets after successful submission - Accessible via /#/staff-grant-extension URL - Add proper routing and module configuration - Include comprehensive form validation with visual feedback - Add blue-tinted styling for containers
- Remove old grant extension form files that were duplicating functionality - Add character limits to staff grant extension form: reason (300 chars), notes (500 chars) - Clean up task status card component to remove old form dependencies
- WIP commit for adding Angular UIRouter routing for the `Staff Grant Extension` feature
- add Angular UIRouter declaration for the `Staff Grant Extension` `TaskDropdown` item - conditionally render the `Staff Grant Extension` `TaskDropdown` item based on the user's `role`
- remove test code
Remove the notes field from the staff grant extension feature as it was not being used in the backend implementation. This simplifies the form and payload structure by removing the unused functionality. Changes made: - Remove notes field from GrantExtensionPayload interface - Remove notes form control from grant extension form - Remove notes textarea from form template - Remove notes field from form reset and payload creation The feature now only includes essential fields: student_ids, task_definition_id, weeks_requested and comment.
- Fix error handling to properly extract specific error messages from API responses - Handle cases where error is directly a string (most common case) - Add debugging logs to help troubleshoot error structures Resolves issue where generic 'Error granting extensions' message was shown instead of specific errors like 'Extensions cannot be granted beyond task deadline'
- Remove development console.log statements used for debugging error extraction - Keep console.error for proper error logging - Clean up code now that error handling is working correctly
This commit is a fully rebased version of the Staff Grant extension feature frontend. It has been rebased from 9.x to 10.0.x with as few changes as possible. Co-authored-by: @JoeMacl Co-authored-by: @SahiruWithanage Co-authored-by: @samindiii Co-authored-by: @rashi-agrawal29 Co-authored-by: @returnMarcco
SteveDala
changed the title
This was referenced Jan 22, 2026
Author
|
@BrianDangDev could you please approve the test run workflows to kick off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a complete rebase of the Staff Grant Extension (SGE) Web functionality introduced in #403. The initial feature was built on
9.x, and this PR migrates the feature to the new10.0.xdevelopment branch.All credit for development of the feature front end goes to @JoeMacl, @SahiruWithanage, @rashi-agrawal29, @returnMarcco, and @samindiii.
Sister branches
Run OnTrack with the latest version of these branches to recreate the environment.
Sister Pull Requests
Repo cleanup
Merging this PR should be followed by closing the following open PRs with a comment that they have been merged into
10.0.x:Type of change
How Has This Been Tested?
The user interface can be navigated to as an Admin, Convenor, or Tutor. After picking a unit, select "Staff Grant Extension" from the task list (after the unit picker) in the top left.
Select a unit, then select some students (or all) to grant the extension to. Provide a reason. Then click Grant Extension.
Testing Checklist:
Checklist: