Fix inconsistent test output in MSYS2 and WSL #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problems
Integration tests run by
sktest.exesometimes produce inconsistent results between WSL and MSYS2 environments.Arial.ttfon WSL (A windows default font not included in theResourcesdirectory)Summary of changes
Fixes have been applied where possible without editing core SplashKit functions. There are some critical issues affecting MSYS2 which cause some tests to fail, but these bugs are not caused by the tests themselves, and will be updated in separate PRs. This PR also includes some minor changes unrelated to environment consistency (such as broken URLs and output messages). These have been addressed to allow the tests to run clearly.
coutadjustments for readabilitycoutmessages to improve result clarityKnown issues not addressed by this PR
Issues with running
sktest.exein MSYS2 environmentThere have been some reported issues running
sktest(at all) on MSYS2. Specifically, the animation test was found to loop indefinitely, and some users found the test runner was freezing even before tests were launched. This has been addressed in Tests investigation issues #132.Issues with download paths in MSYS2
Some download functions are buggy in MSYS2, most likely due to path differences in Windows vs Linux. This affects:
download_musicdownload_fontdownload_bitmapTerminal test fails
Fails on both WSL and MSYS2. Not yet investigated.
UI test fails on MSYS2
Due to an issue with
interface.cpp- addressed in Fix interface out of bounds error on MSYS2 #155.Bundle test fails bitmap freeing
Addressed in Fix bundle freeing: Bitmap resources not being freed #153.
Type of change
How Has This Been Tested?
sktestin WSL and MSYS2 environmentsTesting Checklist
Checklist