fix(query.deps): memoize provided labels rather than declared targets#3369
Merged
Tatskaari merged 1 commit intothought-machine:masterfrom May 29, 2025
Merged
Conversation
The `plz query deps` graph traversal previously memoized targets directly from DeclaredDependencies. This was problematic because a single declared dependency can provide different actual build labels (and therefore different actual dependencies) depending on the context of the target that requires it (via `dep.ProvideFor(target)`). If a declared dependency target `D` was processed for a pareent `P1`, `D` would be marked as done. If another parent `P2` also declared `D` as a dependency, and `D.ProvideFor(P2)` would have yielded additional build labels, these provisions for `P2` would be skipped because `D` was already memoized.
Tatskaari
approved these changes
May 29, 2025
Contributor
Tatskaari
left a comment
Tatskaari
left a comment
There was a problem hiding this comment.
Ah yeah nice catch. I think this makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
plz query depsgraph traversal previously memoized targets directly from DeclaredDependencies. This was problematic because a single declared dependency can provide different actual build labels (and therefore different actual dependencies) depending on the context of the target that requires it (viadep.ProvideFor(target)).If a declared dependency target
Dwas processed for a pareentP1,Dwould be marked as done. If another parentP2also declaredDas a dependency, andD.ProvideFor(P2)would have yielded additional build labels, these provisions forP2would be skipped becauseDwas already memoized.