Add configurable tool_result_max_length for tool result spans#30
Open
sheredega303 wants to merge 1 commit into
Open
Add configurable tool_result_max_length for tool result spans#30sheredega303 wants to merge 1 commit into
sheredega303 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool results can be quite large (RAG docs, JSON responses, DB rows), and the current hardcoded limit sometimes truncates important context.
For evaluation and development, we need access to the full tool output - partial data isn’t enough to properly assess retrieval quality or build reliable eval datasets. Since tools like MLflow, Arize Phoenix, Traceloop, etc support full tool I/O, I think this limit should be configurable rather than hardcoded.