Conversation
mthpower
reviewed
Apr 25, 2018
| [mypy] | ||
| ignore_missing_imports=true | ||
| strict_optional=true | ||
| disallow_any_generics=true |
Contributor
There was a problem hiding this comment.
What is an example of what this would disallow? (the documentation isn't very clear on this)
Contributor
Author
There was a problem hiding this comment.
foo: List rather than foo: List[int]
Contributor
|
👍 |
Contributor
|
@prophile I've fixed a few things here, but would appreciate a review as my approach might not be the best. |
Contributor
Author
|
I don't think we should bypass the layering tests for type checking. Actually I'd claim that the layering tests are correctly exposing dependencies here: where we're implicitly depending on the shape of component A from component B that's still a dependency on A from B even if it's previously not been unmasked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.