Fix failing ktlintCheck on main and unify sign-in flow-meta error logging#10
Merged
brionmario merged 1 commit intoJul 15, 2026
Conversation
- Log flow-meta fetch failures through the shared diagnostic label, matching the rest of the sign-in flow rather than passing the raw exception. - Bring the merged sign-in flow components into ktlint 1.8.0 compliance (when-entry braces and blank lines between multiline when-conditions).
📝 WalkthroughWalkthroughChangesSign-in and formatting updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Malith-19
approved these changes
Jul 15, 2026
brionmario
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow-up on the sign-in flow.
BaseSignInwas logging the raw exception object. I switched it to the samediagnosticLabel(e)helper the rest of the sign-in flow already uses, so the log line stays compact and consistent (typed error code / exception class name) instead of dumping the full exception.ktlintCheckwas failing onmain. I ran the formatter over them —when-entry braces and blank lines between multilinewhenconditions, plus one trailing comma inFlowTemplateResolver. Formatting only, no behaviour change.Verified locally:
./gradlew ktlintCheckis clean (it was red onmainbefore this)./gradlew buildpasses (lint included)Summary by CodeRabbit