Skip to content

Attach the release AAR to the published Maven artifact#12

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:fix/publish-release-artifact
Jul 16, 2026
Merged

Attach the release AAR to the published Maven artifact#12
brionmario merged 1 commit into
thunder-id:mainfrom
brionmario:fix/publish-release-artifact

Conversation

@brionmario

Copy link
Copy Markdown
Member

Summary

  • The release Maven publication declared a groupId/artifactId/version but never called from(components["release"]), so it published an empty POM shell with no .aar attached.
  • Every consumer resolving this library via JitPack (com.github.thunder-id:android-sdks) got a packaging=pom artifact with zero compiled classes, regardless of which ref/commit/tag was requested — this broke any Gradle project trying to depend on a commit/branch snapshot (only the previously-published 0.1.0 release artifact happened to work, likely published before this regressed).
  • Added android.publishing { singleVariant("release") } and wrapped the publication in afterEvaluate so components["release"] is available before from(...) references it.

Test plan

  • ./gradlew publishReleasePublicationToMavenLocal succeeds
  • Verified the produced android-0.1.0.aar in ~/.m2 actually contains classes.jar (previously it did not)
  • CI build passes

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@brionmario, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f224811-5337-4205-b136-f768e41898a6

📥 Commits

Reviewing files that changed from the base of the PR and between a4b586c and 8dbc9ac.

📒 Files selected for processing (1)
  • build.gradle.kts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brionmario brionmario changed the title fix: attach the release AAR to the published Maven artifact Attach the release AAR to the published Maven artifact Jul 16, 2026
@brionmario
brionmario force-pushed the fix/publish-release-artifact branch from 84216f6 to 8dbc9ac Compare July 16, 2026 11:46
@brionmario
brionmario merged commit b069ba4 into thunder-id:main Jul 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants