Skip to content

Upgrade ktlint tooling to 1.8.0 and tidy sign-in logging#7

Merged
UdeshAthukorala merged 1 commit into
thunder-id:mainfrom
UdeshAthukorala:chore/upgrade-ktlint-and-tidy-logging
Jul 15, 2026
Merged

Upgrade ktlint tooling to 1.8.0 and tidy sign-in logging#7
UdeshAthukorala merged 1 commit into
thunder-id:mainfrom
UdeshAthukorala:chore/upgrade-ktlint-and-tidy-logging

Conversation

@UdeshAthukorala

@UdeshAthukorala UdeshAthukorala commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

While updating the lint tooling I bumped the ktlint Gradle plugin from 12.1.1 to 14.2.0 and pinned the ktlint engine to 1.8.0. The newer plugin is needed to run the 1.8.0 engine, and it keeps us on the current release. Running the updated ruleset reformatted a fair number of files — line wrapping, trailing commas on multi-line declarations, and braces on multi-branch whens. All of that is formatting only, no behaviour changes.

I also tidied up the app-native sign-in flow while I was in there:

  • Logging now writes just the flow status, the input/action counts, and the typed error code from IAMException, instead of dumping the full response object and raw exceptions to logcat. Errors still reach the app the same way, through signInState.error and the onError callback, so nothing changes for consumers.
  • The form now clears its entered field values once the flow completes and when it leaves the screen, so it does not hold on to input after it is done with it.

Testing

Built and ran the quickstart sample on an Android 14 emulator against a local ThunderID server and walked the sign-in flow end to end. The app launches to the home screen, tapping Sign in pulls the credential form from the server (POST /flow/execute), and submitting valid credentials completes authentication and lands on the user profile. I also confirmed the form fields are cleared after a successful sign-in.

Home Sign-in form (from server) Signed in

Also verified locally:

  • ./gradlew ktlintCheck is clean
  • ./gradlew build passes (lint included, no errors)
  • all 24 unit tests pass
  • the quickstart sample assembles against the updated SDK

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@UdeshAthukorala, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fa565d8b-564b-41f1-bc68-efe7ddff1db7

📥 Commits

Reviewing files that changed from the base of the PR and between e22131a and 16fc413.

📒 Files selected for processing (17)
  • build.gradle.kts
  • src/main/kotlin/dev/thunderid/android/Models.kt
  • src/main/kotlin/dev/thunderid/android/StorageAdapter.kt
  • src/main/kotlin/dev/thunderid/android/ThunderIDClient.kt
  • src/main/kotlin/dev/thunderid/android/ThunderIDError.kt
  • src/main/kotlin/dev/thunderid/android/auth/FlowExecutionClient.kt
  • src/main/kotlin/dev/thunderid/android/http/HttpClient.kt
  • src/main/kotlin/dev/thunderid/android/token/JWKSCache.kt
  • src/main/kotlin/dev/thunderid/android/token/TokenStore.kt
  • src/main/kotlin/dev/thunderid/android/token/TokenValidator.kt
  • src/main/kotlin/dev/thunderid/compose/components/flow/Callback.kt
  • src/main/kotlin/dev/thunderid/compose/components/presentation/auth/SignIn.kt
  • src/main/kotlin/dev/thunderid/compose/components/presentation/auth/SignUp.kt
  • src/main/kotlin/dev/thunderid/compose/components/presentation/user/UserDropdown.kt
  • src/main/kotlin/dev/thunderid/compose/components/presentation/user/UserProfile.kt
  • src/test/kotlin/dev/thunderid/android/ThunderIDClientTest.kt
  • src/test/kotlin/dev/thunderid/compose/ComponentTests.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@UdeshAthukorala
UdeshAthukorala force-pushed the chore/upgrade-ktlint-and-tidy-logging branch from 43bb253 to 7cf0bf2 Compare July 13, 2026 06:53
- Bump the ktlint Gradle plugin 12.1.1 -> 14.2.0 and pin the ktlint
  engine to 1.8.0, then apply the resulting auto-formatting across the
  codebase (line wrapping, trailing commas, when-branch braces).
- Refine the app-native sign-in flow logging to emit concise, structured
  diagnostics (flow status, input/action counts, and typed error codes)
  instead of verbose response/exception dumps.
- Clear the entered sign-in form fields once the flow completes and when
  the form leaves the screen, so input state is not retained after use.
@UdeshAthukorala
UdeshAthukorala force-pushed the chore/upgrade-ktlint-and-tidy-logging branch from 7cf0bf2 to 16fc413 Compare July 13, 2026 06:53
@UdeshAthukorala
UdeshAthukorala merged commit 9004cea into thunder-id:main Jul 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants