Upgrade ktlint tooling to 1.8.0 and tidy sign-in logging#7
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
43bb253 to
7cf0bf2
Compare
- Bump the ktlint Gradle plugin 12.1.1 -> 14.2.0 and pin the ktlint engine to 1.8.0, then apply the resulting auto-formatting across the codebase (line wrapping, trailing commas, when-branch braces). - Refine the app-native sign-in flow logging to emit concise, structured diagnostics (flow status, input/action counts, and typed error codes) instead of verbose response/exception dumps. - Clear the entered sign-in form fields once the flow completes and when the form leaves the screen, so input state is not retained after use.
7cf0bf2 to
16fc413
Compare
While updating the lint tooling I bumped the ktlint Gradle plugin from
12.1.1to14.2.0and pinned the ktlint engine to1.8.0. The newer plugin is needed to run the 1.8.0 engine, and it keeps us on the current release. Running the updated ruleset reformatted a fair number of files — line wrapping, trailing commas on multi-line declarations, and braces on multi-branchwhens. All of that is formatting only, no behaviour changes.I also tidied up the app-native sign-in flow while I was in there:
IAMException, instead of dumping the full response object and raw exceptions to logcat. Errors still reach the app the same way, throughsignInState.errorand theonErrorcallback, so nothing changes for consumers.Testing
Built and ran the quickstart sample on an Android 14 emulator against a local ThunderID server and walked the sign-in flow end to end. The app launches to the home screen, tapping Sign in pulls the credential form from the server (
POST /flow/execute), and submitting valid credentials completes authentication and lands on the user profile. I also confirmed the form fields are cleared after a successful sign-in.Also verified locally:
./gradlew ktlintCheckis clean./gradlew buildpasses (lint included, no errors)