Implement federated sign-in buttons and associated logic for Google and GitHub#8
Conversation
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Adds federated (social) sign-in support to the Android SDK — Google, GitHub, and passkey trigger actions are now rendered and wired into the
SignInflow, backed by a Custom Tabs browser round-trip for the OAuth redirect. This also fixes a flow-parsing bug that was silently dropping those buttons, and cleans up leftover/duplicate code from earlier WIP.Approach
SignIn.kt) — the real Flow Execution API identifies a node byrefon the flatdata.actionsarray but byidon the matching node insidedata.meta.components(same value, different field per side). The existing lookup comparedref==ref/id==idonly, so it never matched across the two shapes — anyACTIONnode under aBLOCK, including the Google/GitHub/passkey triggers, silently rendered nothing. FixedenrichActionsandActionComponentViewto key offref ?: idon both sides.FederatedAuthSession— bridges the browser round-trip forTRIGGER(federated) actions: launches a Custom Tab for the provider redirect and suspends until the host Activity forwards the deep-link callback viaonRedirect, withcancelIfPendingto resolve gracefully if the user dismisses the browser. Added the missingandroidx.browserdependency this needed to compile.GoogleButton,GitHubButton) — dedicated, styled trigger buttons using the official brand marks, added as drawable resources for pixel-accurate rendering rather than hand-drawn glyphs.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit
New Features
Bug Fixes