Update transitive dependency overrides to fix security audit - #4191
Conversation
Bump brace-expansion, js-yaml, and shell-quote overrides to patched versions to satisfy the pnpm audit high-severity gate. - brace-expansion: cover <1.1.16 and >=3.0.0 <5.0.7 (GHSA-3jxr-9vmj-r5cp) - js-yaml: >=4.0.0 <4.3.0 -> 4.3.0 (GHSA-52cp-r559-cp3m) - shell-quote: >=1.8.5 globally (GHSA-395f-4hp3-45gv)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated ChangesDependency override remediation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates pnpm transitive dependency overrides (and regenerates the lockfile) to restore the repo-wide pnpm audit --audit-level=high security gate by forcing patched versions of vulnerable deep dependencies used by tooling like Docusaurus and related dev-server chains.
Changes:
- Replaced the docs-scoped
shell-quoteoverride with a global override (>=1.8.5) so it applies to the actual transitive path(s). - Updated
brace-expansionoverrides to cover both the 1.x and 3.x/4.x vulnerable ranges with patched versions. - Updated the
js-yamloverride for the vulnerable>=4.0.0 <4.3.0range and regeneratedpnpm-lock.yaml.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates security-motivated overrides to patched versions for affected transitive dependencies. |
| pnpm-lock.yaml | Lockfile regeneration reflecting the new override resolutions (e.g., shell-quote/brace-expansion/js-yaml). |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Purpose
Fixes the repo-wide Security Audit CI gate (
pnpm audit --audit-level=high), which started failing because three advisories were re-scoped to wider version ranges than the existing transitive-dependency overrides inpnpm-workspace.yamlcovered. This is not tied to any feature change; it surfaced on open PRs (e.g. #4161) because the gate runs on every PR.All three packages are deep transitive dependencies (via docusaurus, eslint, rimraf, webpack-dev-server), so they are updated through pnpm
overridesrather than a directpackage.jsonbump.Approach
Updated the stale overrides to patched versions:
<1.1.16(1.x line, previously unhandled) and>=3.0.0 <5.0.7(old override capped at5.0.5, still vulnerable). Now overrides<1.1.16 -> 1.1.16and>=3.0.0 <5.0.7 -> 5.0.7.>=4.0.0 <4.3.0; old override capped at4.2.0, still vulnerable. Now>=4.0.0 <4.3.0 -> 4.3.0.parse()): advisory<=1.8.4. The old@thunderid/docs>shell-quote: 1.8.4scope only matched a direct child of the docs package, so it never applied to the actual...launch-editor>shell-quotepath. Replaced with a globalshell-quote: >=1.8.5override.Regenerated
pnpm-lock.yaml. Localpnpm audit --ignore-registry-errors --audit-level=highnow reports 0 high-severity findings.Related Issues
N/A
Checklist
Security checks
Summary by CodeRabbit