Conversation
Shellcheck doesn't like A && B || C because if B fails, C will run even when A is true.. just fixed with an if statement
Added sections for installation methods and a placeholder for additional content. Add files via upload add an image of dwmbar in README Updated README with a new screenshot of dwmbar Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update README with installation instructions (#46) Added sections for installation methods and a placeholder for additional content. Add files via upload add an image of dwmbar in README Updated README with a new screenshot of dwmbar Update README.md Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
thytom
left a comment
thytom
left a comment
There was a problem hiding this comment.
Happy to approve this. I just reset main back to before the merge, so this will just make identical changes and new cloners will be none the wiser, and people pulling will just need to git fetch && git reset --hard origin/main to cope.
| PREFIX=' ' | ||
|
|
||
| get_time() | ||
| { |
There was a problem hiding this comment.
I know I just asked you to squash all your commits down so do not worry this is just advice I'll still happily accept this PR: Commits best organised so that they change one feature at a time. That would mean in this project:
- Add config_sync.sh, containing the new file and changes to install.sh and dwmbar + the readme entry that concerns it
- Change format in modules/time for the small change to modules/time.
There was a problem hiding this comment.
If you've done it right in your PR, the order of commits can matter, but not here. I usually organise them with a rebase into:
- Required Api/infrastructure changes first (if needed)
- Then add the feature + documentation if required, now that the required infra is committed.
Some people prefer to split up the docs or keep things even smaller, I prefer to have commits that move the code along in single functional chunks, with each commit fully functional.
| $ cd dwmbar | ||
| $ sudo ./install.sh | ||
| ``` | ||
| </details> |
There was a problem hiding this comment.
Neat trick, which I have stolen for my work projects 👀
There was a problem hiding this comment.
very useful for different installation methods!
There was a problem hiding this comment.
also, nothing new... was actually used in the README quite a bit already ;)
perhaps the owner does not remember the changes made to their repository... wink wink...
glad you can use it in your work! quite a bit of HTML works on markdown!
There was a problem hiding this comment.
It’s been quite a few years 😭 I think Baitinq the other founder did most of the README.
2 participants
Added sections for installation methods and a placeholder for additional content.
Add files via upload
add an image of dwmbar in README
Updated README with a new screenshot of dwmbar
Update README.md
Update README.md
Update README.md
Update README with installation instructions (#46)
Added sections for installation methods and a placeholder for additional content.
Add files via upload
add an image of dwmbar in README
Updated README with a new screenshot of dwmbar
Update README.md
Update README.md