Skip to content

api: sync API V3 keyspace identity protos - #47

Open
disksing wants to merge 35 commits into
release-8.5-keyspacefrom
apiv3
Open

api: sync API V3 keyspace identity protos#47
disksing wants to merge 35 commits into
release-8.5-keyspacefrom
apiv3

Conversation

@disksing

@disksing disksing commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Downstream differences

  • Keep the release-line schema and file formatting instead of importing unrelated changes from upstream master.
  • Keep the Resource Manager protocol and generated bindings unchanged from release-8.5-keyspace.
  • externalworkloadpb, keyspace_encryptionpb, DfsStatScope, and the newer GC KeyspaceScope are absent from this release line, so their upstream-only edits are not reintroduced.
  • For #1505, retain only the Namespace service split and regenerate against the release-line schema; the pdpb comment from that upstream commit was already present from the #1458 port.

Validation

  • make check
  • GOPROXY=https://goproxy.cn,direct GOSUMDB=off go test ./...
  • Re-ran scripts/generate_go.sh; generated output had zero drift.
  • go mod tidy completed with no go.mod or go.sum changes.
  • git diff --check
  • Reviewed all new proto indentation against each target-base file style.
  • Verified proto/resource_manager.proto, pkg/resource_manager/resource_manager.pb.go, and the Resource Manager lock definition have zero diff from the target base.

Traceability

disksing added 2 commits May 1, 2026 00:55
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
disksing and others added 13 commits May 1, 2026 10:07
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jun 30, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 11 committers have signed the CLA.

✅ rleungx
✅ disksing
❌ glorv
❌ JmPotato
❌ ekexium
❌ tiancaiamao
❌ wshwsh12
❌ lcwangchao
❌ hbisheng
❌ MyonKeminta
❌ you06
You have signed the CLA already but the status is still pending? Let us recheck it.

disksing and others added 12 commits June 30, 2026 15:16
Signed-off-by: disksing <i@disksing.com>
* Add new GC API

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Update definition of keyspace specifier in requests to avoid potential misuses

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Update to the latest design

* Update protocol

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Fix missing field

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

---------

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

Signed-off-by: disksing <i@disksing.com>
* feat(resource_manager): add keyspace support

Signed-off-by: JmPotato <github@ipotato.me>

* Use KeyspaceIDValue wrapper

Signed-off-by: JmPotato <github@ipotato.me>

---------

Signed-off-by: JmPotato <github@ipotato.me>

Signed-off-by: disksing <i@disksing.com>
* proto/pdpb: add global gc barrier API for pd

Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>

* address comment

Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>

* update GetAllKeyspacesGCStatesResponse

Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>

---------

Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>

Signed-off-by: disksing <i@disksing.com>
…te (#1461)

* Support excluding GC barriers for GetGCState and GetAllKeyspacesGCState

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Add exclude global gc barriers parameter

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

---------

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

Signed-off-by: disksing <i@disksing.com>
* add cross AZ traffic in resource consumption

Signed-off-by: glorv <glorvs@163.com>

* add network detail in exec detail

Signed-off-by: glorv <glorvs@163.com>

* use distinct read and write network traffic bytes

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: glorv <glorvs@163.com>

Signed-off-by: disksing <i@disksing.com>
…info (#1308)

* kvrpcpb: Add more fields in CommitRequest/Response to give more lock info

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

* Add `mvcc_info` to `TxnLockNotFound`

* Add debug info

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

* Add CommitRole

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

* Update proto/kvrpcpb.proto

---------

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>

Signed-off-by: disksing <i@disksing.com>
* kvrpcpb: add request origin to context

Signed-off-by: Ziqian Qin <eke@fastmail.com>

* make

Signed-off-by: Ziqian Qin <eke@fastmail.com>

---------

Signed-off-by: Ziqian Qin <eke@fastmail.com>

Signed-off-by: disksing <i@disksing.com>
…ared lock in pessimistic transacitons. (#1374)

* reserve Op for shared lock

Signed-off-by: you06 <you1474600@gmail.com>

* distinguish between shared prewrite locks and shared pessimistic locks (#1377)

* let LockInfo carry the full txn info when it's shared

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* move the todo comment to the proper place

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* distinguish between shared prewrite locks and shared pessimistic locks

Signed-off-by: zyguan <zhongyangguan@gmail.com>

---------

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* update kvproto

Signed-off-by: you06 <you1474600@gmail.com>

* add embed shared_lock_infos

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
Co-authored-by: zyguan <zhongyangguan@gmail.com>

Signed-off-by: disksing <i@disksing.com>
* tikvpb: add batch command transport timestamps

Add client_send_time_ns to BatchCommandsRequest and tikv_send_time_ns
to BatchCommandsResponse so callers can track when a batch request
leaves the client and when TiKV finishes preparing the response.

Signed-off-by: Bisheng Huang <hbisheng@gmail.com>

* proto: update proto lock for transport timestamps

Refresh scripts/proto.lock for the new batch command transport
timestamp fields so the compatibility metadata matches the proto
schema.

Signed-off-by: Bisheng Huang <hbisheng@gmail.com>

---------

Signed-off-by: Bisheng Huang <hbisheng@gmail.com>

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
* kvrpcpb: add `UndeterminedResult` to `KeyError`

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

* txn: move `UndeterminedResult` to region error

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

---------

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
Signed-off-by: disksing <i@disksing.com>
lcwangchao and others added 3 commits June 30, 2026 15:58
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>

Signed-off-by: disksing <i@disksing.com>
* coprocessor: add TiCI estimate count rpc

* Update proto/tikvpb.proto

Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>

* tikvpb: fix TiFlash comment casing

---------

Co-authored-by: cfzjywxk <cfzjywxk@gmail.com>

Signed-off-by: disksing <i@disksing.com>
Sync the final protocol changes from pingcap/kvproto#1458 at 7022f46937bc35125fb6d65aad5a0eedd59e7cfd onto release-8.5-keyspace.

Preserve the downstream release schema and regenerate Go bindings and proto.lock with the downstream toolchain.

Signed-off-by: disksing <i@disksing.com>
@disksing disksing changed the title add API V3 keyspace identity protos api: sync API V3 keyspace identity protos Jul 27, 2026
Keep the release-8.5-keyspace Resource Manager schema and generated bindings unchanged as requested.

Signed-off-by: disksing <i@disksing.com>
@disksing
disksing marked this pull request as ready for review July 28, 2026 01:07
disksing added 4 commits July 29, 2026 13:11
Match new proto blocks to each release file's existing indentation style.

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.