docs: add docs for agnocast tracepoint#380
Conversation
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
There was a problem hiding this comment.
Since this is still a draft, it might be a bit early to mention this, but one minor point:
Currently, the alphabetical order puts Agnocast before the core features in both the sidebar and the page bottom navigation (Next/Previous).
I think it would be more intuitive to have the core features first, followed by the Agnocast points.
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
|
@xygyo77 Background: Why this approach was chosen Please let me know if you have any thoughts on the above. |
xygyo77
left a comment
There was a problem hiding this comment.
Thanks for the detailed investigation and explanation regarding the awesome-pages plugin issue.
I understand the reason for choosing the flat format to avoid the plugin's bug and preserve the URLs. The change in the sidebar nesting is not a problem.
However, I’ve left a comment on the “File changes” tab. Please take a look at that as well.
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
|
@kobayu858 |
Description
Added tracepoint definition documentation for Agnocast. Two new files are created for initialization and runtime tracepoints respectively, and links and descriptions are added to the existing index.md and agnocast.md.
Related links
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.