Add diagnostic logging for DisableUpdatePopup (#312)#342
Merged
Conversation
- Log the exact settings file path at load time. - Log 'Settings: DisableUpdatePopup = <value>' at startup (after ApplySettings). - When an update check detects a newer version and the flag is true, log 'Update Popup is disabled (DisableUpdatePopup=true)' instead of (or before) showing the dialog. This will help confirm whether the correct mcec.settings is being loaded for installed vs side-by-side copies, and whether the guard is being reached. Refs #312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added targeted diagnostic logging to troubleshoot why DisableUpdatePopup=true is sometimes ignored (especially on installed/default instances).
This matches the exact file the reporter posted in #312.
Refs #312