fix mismatch snapshot #2499
Closed
fix mismatch snapshot #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Jest snapshots to match current rendered output (including updated snapshot header URLs, logo assets, and added alt text), and adjusts CI workflows.
Changes:
- Re-generated multiple Jest snapshot files under
src/___new___/components/**/__snapshots__/. - Updated GitHub Actions workflow action versions in
validate.ymlandvale.yml. - Added new text to Calico Cloud v22.2 release notes.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/new/components/SelectDocs/test/snapshots/index.test.tsx.snap | Snapshot updated (logo alt text + updated logo asset path). |
| src/new/components/ProductInfo/test/snapshots/index.test.tsx.snap | Snapshot updated (adds alt attributes to images). |
| src/new/components/ProductComparison/test/snapshots/index.test.tsx.snap | Snapshot updated (removes previously-rendered logo markup). |
| src/new/components/HomepageHeader/test/snapshots/index.test.tsx.snap | Snapshot updated (adds logo image + new snapshot header link). |
| src/new/components/FeatureTableComparison/test/snapshots/index.test.tsx.snap | Snapshot header link updated. |
| src/new/components/Explore/test/snapshots/index.test.tsx.snap | Snapshot header link updated. |
| calico-cloud_versioned_docs/version-22-2/release-notes/index.mdx | Adds new release note text (currently appears to be placeholder and contains a typo). |
| .github/workflows/validate.yml | Changes action versions used for checkout/setup-node (currently set to @v6). |
| .github/workflows/vale.yml | Changes action versions used for checkout/setup-node (currently set to @v6). |
|
|
||
| #### Dashboards are GA | ||
|
|
||
| Here's a thing with a tigera mistakee. |
There was a problem hiding this comment.
Typo: "mistakee" should be "mistake".
Suggested change
| Here's a thing with a tigera mistakee. | |
| Here's a thing with a tigera mistake. |
Comment on lines
+14
to
+16
| Here's a thing with a tigera mistakee. | ||
|
|
||
|
|
There was a problem hiding this comment.
The added sentence "Here's a thing with a tigera mistakee." reads like placeholder text and doesn't match the surrounding release-note content. Please remove it or replace it with a meaningful release note entry (and avoid leaving extra blank lines).
Suggested change
| Here's a thing with a tigera mistakee. |
Collaborator
Author
|
This was just for testing #2498. Tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: