docs(constitution): shrink MCP allowlist section to load-bearing boundaries#28
Conversation
…boundaries June-gloom Phase 1, CONSTITUTION clean move. The full MCP safety model (ad-hoc rejection + --allow-adhoc-targets, the mcp=ro|rw + confirm:true write gate, the scoped tool surface, the centrs:// resources, validate dry-run) is documented in commands/mcp/README.md (Safety model / Tools / Resources / Transports sections). Keep the two cross-cutting boundaries — authorization = the CDB allowlist (linking the __default__ rule), and stdio-only (HTTP is the proxy's job) — plus a pointer; move the mechanics. CONSTITUTION 479→468. MD051 lint passes; lint:ci green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 42 minutes and 22 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesMCP Boundary Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates docs/CONSTITUTION.md to de-duplicate MCP safety-model details by keeping only the “load-bearing” MCP boundaries in the constitution and pointing readers to commands/mcp/README.md for the full model.
Changes:
- Shrinks the MCP allowlist section to focus on CDB allowlist authorization and stdio-only transport.
- Moves detailed MCP mechanics/tool/resource documentation references to
commands/mcp/README.md.
| - **Authorization is the CDB allowlist.** RouterOS-facing tools resolve targets | ||
| through the CDB only; an unregistered target is rejected | ||
| (`cdb/target-not-registered`), and `__default__` never widens the allowlist (see | ||
| Identity and CDB). The off-by-default `--allow-adhoc-targets` is the only escape. |
There was a problem hiding this comment.
Good catch — reworded. The flag is parsed (src/mcp/config.ts) but commands/mcp/README.md confirms it's reserved (no inline host+credential schema today), so the line now reads: "reserved for future inline-target flows — today no RouterOS-facing tool exposes an inline host+credential schema, so the CDB allowlist is the only active target source." No implied current bypass.
…bypass Address Copilot on PR #28: the flag is parsed but no RouterOS-facing tool exposes an inline host+credential schema today (commands/mcp/README.md), so calling it "the only escape" overstated it. Reword to match: reserved for future inline-target flows; the CDB allowlist is the only active target source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
June-gloom Phase 1 — CONSTITUTION clean move (MCP allowlist)
First of the CONSTITUTION clean moves now that the MATRIX restructure is done. The full MCP safety model lives in
commands/mcp/README.md(dedicated "Safety model — the CDB is the allowlist", "Tools", "Resources", "Transports" sections), so this is dedup.What changes
docs/CONSTITUTION.mdMCP section: keep the two load-bearing boundaries — authorization = the CDB allowlist (linking the__default__-never-widens rule kept in Identity and CDB), and stdio-only (HTTP is the proxy surface's job) — plus themcp=ro|rw+confirm:truewrite-gate mention and a pointer. Move the mechanics (ad-hoc rejection +--allow-adhoc-targets, the scoped tool list, thecentrs://resources,validatedry-run) to the mcp README. ~28 → ~13 lines.Verification
bun run lint:ci: markdownlint 0 errors (MD051 passes), cspell / secretlint / agent-lint cleanDocs only.
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation