fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows - #73
Open
JohnieXu wants to merge 2 commits into
Open
fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows#73JohnieXu wants to merge 2 commits into
JohnieXu wants to merge 2 commits into
Conversation
…oading errors on Windows
Collaborator
|
@JohnieXu 我们很感激您的贡献,这个 PR 对我们来说非常重要。根据我们的政策,您为该项目贡献代码需要签署 CLA,完成签署之后我们将合入该 PR |
leeekyrie
approved these changes
May 1, 2026
Author
|
@leeekyrie CLA signed, please merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
Summary
spawn rspeedy ENOENTerror when runningnpm run run:androidon Windowssparkling-app-clispawnsrspeedywithshell: false, but on Windows, therspeedybinary innode_modules/.binis a Unix shell script that cannot be executed directlyRelated issues
Fix #63
Changes
shell: falsetoshell: process.platform === 'win32' ? true : falseso that Windows can properly execute batch files likegradlew.batHow to test
1.create new project with
npm create sparkling-app@latest2.install deps
3.run
npm run run:androidChecklist
CONTRIBUTING.md.