Skip to content

fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows - #73

Open
JohnieXu wants to merge 2 commits into
tiktok:mainfrom
JohnieXu:fix/windows-rspeedy-spawn
Open

fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows#73
JohnieXu wants to merge 2 commits into
tiktok:mainfrom
JohnieXu:fix/windows-rspeedy-spawn

Conversation

@JohnieXu

@JohnieXu JohnieXu commented Apr 24, 2026

Copy link
Copy Markdown

Fixes #63

Summary

  • Fix spawn rspeedy ENOENT error when running npm run run:android on Windows
  • The issue occurs because sparkling-app-cli spawns rspeedy with shell: false, but on Windows, the rspeedy binary in node_modules/.bin is a Unix shell script that cannot be executed directly

Related issues

Fix #63

Changes

  • exec.ts: Changed shell: false to shell: process.platform === 'win32' ? true : false so that Windows can properly execute batch files like gradlew.bat

How to test

1.create new project with npm create sparkling-app@latest
2.install deps
3.run npm run run:android

Checklist

  • I read CONTRIBUTING.md.
  • I linked a related issue (or explained why this is standalone).
  • I ran relevant checks
  • I updated docs/examples (if needed).
  • I added/updated tests (if applicable), or explained why not.

@cla-assistant

cla-assistant Bot commented Apr 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@JohnieXu JohnieXu changed the title fix(sparking-cli): (Windows) Failed to load app config via ESM fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows Apr 24, 2026
@leeekyrie

Copy link
Copy Markdown
Collaborator

@JohnieXu
We greatly appreciate your contribution, and this PR is very valuable to us. Per our project policy, you will need to sign the CLA before we can merge your code contribution. Once you complete the CLA signing, we will proceed to merge this PR.

我们很感激您的贡献,这个 PR 对我们来说非常重要。根据我们的政策,您为该项目贡献代码需要签署 CLA,完成签署之后我们将合入该 PR

@JohnieXu

Copy link
Copy Markdown
Author

@leeekyrie CLA signed, please merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: (Windows) Failed to load app config via ESM

2 participants