version 1.2.4#12
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 7 8 +1
Lines 1320 1333 +13
=======================================
+ Hits 1318 1331 +13
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the gem’s build process to default to portable C-extension binaries (avoiding host-instruction crashes) while adding an opt-in mechanism to tune or maximize CPU-specific optimizations at install time, and documents the new behavior.
Changes:
- Introduces a pure, testable CPU-flag selection module (
SmarterJSON::CpuFlags) plus RSpec coverage for its contract. - Updates
extconf.rbto probe compiler support for candidate CPU flags and apply them based onSMARTER_JSON_PERFORMANCE. - Documents the new build-time performance levels in the README/docs and records the release notes; bumps the gem version.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/cpu_flags_spec.rb | Adds RSpec contract tests for CPU optimization flag selection behavior. |
| ext/smarter_json/cpu_flags.rb | Implements mkmf-free normalization/selection of CPU flags for portable/tuned/max builds. |
| ext/smarter_json/extconf.rb | Integrates compiler probing + env-controlled CPU flag selection into build optflags. |
| README.md | Documents SMARTER_JSON_PERFORMANCE build-time performance/portability tradeoffs and examples. |
| docs/_introduction.md | Adds introduction docs section explaining build-time performance tuning and safety. |
| CHANGELOG.md | Records the portable-default change and the new build option for the 1.2.4 entry. |
| lib/smarter_json/version.rb | Bumps gem version constant to 1.2.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see changelog