feat: add keyboard shortcuts to screenshot review page#250
Open
tim-richter wants to merge 2 commits into
Open
Conversation
…roval Adds ArrowLeft/ArrowRight to navigate between screenshots and 'a' to approve the current screenshot when on the review page.
🦋 Changeset detectedLatest commit: 8f5cdaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
userEvent.keyboard in vitest browser mode routes through playwright's keyboard.down/insertText which doesn't reliably trigger window-level keydown listeners. Dispatch a real KeyboardEvent on window so the tests exercise the actual handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add keyboard shortcuts to the screenshot review page for improved navigation and approval workflow. Users can now use arrow keys to navigate between screenshots and the 'a' key to approve the current screenshot.
Changes
useEffecthook to listen for keyboard events with smart filtering (ignores modifier keys, content-editable elements, and form inputs)ArrowLeft: Navigate to previous screenshot (if available)ArrowRight: Navigate to next screenshot (if available)a: Approve current screenshot (if not already approved)@cappa/serverImplementation Details
useNavigatefrom react-router to handle screenshot navigationhttps://claude.ai/code/session_01KBiQotWVr35kYHJWVUN3C3