fix: eraser doesn't affect undo history if it didn't actually erase anything#80
Merged
timcreatedit merged 1 commit intotimcreatedit:mainfrom Jun 6, 2025
Merged
Conversation
TecReaGroup
force-pushed
the
main
branch
2 times, most recently
from
495ef23 to
cdd685a
Compare
timcreatedit
requested changes
Jun 2, 2025
Owner
timcreatedit
left a comment
timcreatedit
left a comment
There was a problem hiding this comment.
Thank you so much for your contribution! I have a couple tiny comments, otherwise this looks good :)
Owner
|
Hi @TecReaGroup, you re-requested a review but it seems like you didn't change anything. Did you see my comments? |
TecReaGroup
force-pushed
the
main
branch
2 times, most recently
from
441d9c6 to
10aba12
Compare
Contributor
Author
|
OK, I have modified it according to your request, please review it. Note: Thank you for your tolerance. This is the first time to submit a PR formally. There are many mistakes. I am so sorry. |
timcreatedit
changed the title
timcreatedit
approved these changes
Jun 6, 2025
Owner
|
Thank you so much for your contribution @TecReaGroup ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update _erasePoint, and check if the erasing effect is effective, avoid affecting the undo stack.
Checklist