Add semantic classNames and data-testid attributes to critical interactive controls#345
Closed
Add semantic classNames and data-testid attributes to critical interactive controls#345
Conversation
Copilot
AI
changed the title
a
Add semantic classNames and data-testid attributes to critical interactive controls
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds semantic classNames and data-testid attributes to critical buttons and controls across the Pulse UI client to enable easier styling and future Playwright-based testing.
What Changed
Added 22 semantic identifiers to key interactive elements across major pages, focusing on the most important 4-5 controls per page as requested:
SQL Editor Page
sql-run-all-button,sql-run-selected-button,sql-run-line-buttonclasses with corresponding data-testid attributessql-code-editorclass to the main editorsql-result-gridclass and data-testid to the query results tableNavigation Components
Dashboard Management
dash-{action}-buttonConnection Management
conn-{action}-buttonToast Notifications
toast-notificationsemantic class to the Notyf notification systemTechnical Implementation
Benefits
The implementation follows best practices for test automation while maintaining the existing UI behavior and visual design.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.