Skip to content

feat(cli): add run phase timings ⏱️#126

Merged
timfennis merged 4 commits intomasterfrom
feat-run-phase-timings
Mar 24, 2026
Merged

feat(cli): add run phase timings ⏱️#126
timfennis merged 4 commits intomasterfrom
feat-run-phase-timings

Conversation

@timfennis
Copy link
Copy Markdown
Owner

Summary

  • add a --time flag to ndc run to print lexing, parsing, analyser, compiling, and running timings
  • keep phase timing independent from the existing trace feature
  • move timing bookkeeping into a dedicated interpreter timing module to keep the interpreter pipeline readable

Verification

  • cargo fmt --all
  • cargo test -p ndc_bin -p ndc_interpreter
  • cargo run -p ndc_bin -- run --time tests/programs/014_comprehensive/001_for_capture.ndc

@timfennis
Copy link
Copy Markdown
Owner Author

@codex please review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ffed1cf86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@timfennis timfennis merged commit 4d81c55 into master Mar 24, 2026
1 check passed
@timfennis timfennis deleted the feat-run-phase-timings branch March 24, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant