Remove stale renderer compile toggles (PATCH_STITCHING, USE_FOG_COLLAPSE)#194
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Remove stale renderer compile toggles (PATCH_STITCHING, USE_FOG_COLLAPSE)#194cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
…LAPSE Both macros were unconditionally defined for shipped builds; guarded code was dead alternate paths. Unfold to the active behavior only. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two preprocessor-only toggles that were always enabled for normal engine builds and only hid alternate (unused) code paths.
Flags removed
PATCH_STITCHINGtr_local.hfiles for OpenGL and Vulkan renderers. The#elsebranches (non-stitching allocation viaHunk_Alloc) were never compiled in shipped configurations.USE_FOG_COLLAPSEtr_local.h. OpenGL never used this symbol; Vulkan fog-collapse logic is the only supported path.Behavioral parity
./scripts/compile_engine.sh vulkan(Release) succeeded../scripts/compile_engine.sh opengl(Release) succeeded.ctestinbuild-vk-Release: 26/26 passed (smoke, renderer checks, unit tests).No CMake options or runtime cvars were removed; this is compile-time dead-branch cleanup only.