Skip to content

Conversation

@timfox
Copy link
Owner

@timfox timfox commented Jan 27, 2026

Note

Modernizes build system and CI to reduce external dependencies and fix Linux runner issues.

  • Inlines a minimal FindSDL2 implementation into CMakeLists.txt, removes cmake_modules/FindSDL2.cmake, standardizes SDL2::Core/SDL2::Main targets, hard-fails when SDL2 is not found, and supports SDL2_PATH (used on macOS/Homebrew)
  • Changes default SKIP_IDPAK_CHECK to ON
  • CI: On Ubuntu runners, removes conflicting Azure/Microsoft APT sources before installs; retains 32-bit deps for x86 and standard deps for x86_64/arm64; macOS builds pass SDL2_PATH from Homebrew

Written by Cursor Bugbot for commit ba3c865. This will update automatically on new commits. Configure here.

@timfox timfox merged commit 014caf6 into honeycomb-bloom-fix Jan 27, 2026
28 checks passed
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 25

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

/opt/local
/opt
/sw
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDL2_PATH CMake variable ignored, breaking macOS builds

High Severity

The inline SDL2 finder uses $ENV{SDL2_PATH} (environment variable) but the macOS CI workflow passes -DSDL2_PATH="${SDL2_PREFIX}" (CMake cache variable). These are different namespaces, so the Homebrew SDL2 path won't be used. Since /opt/homebrew (Apple Silicon Homebrew prefix) isn't in the hardcoded hint paths, macOS builds will fail to find SDL2.

Fix in Cursor Fix in Web

)

# Try SDL2::SDL2 (split main and core lib), or fallback to sdl2 for older systems
set(_SDL2_LIB_NAMES SDL2 SDL2-2.0 SDL2d)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeBSD SDL2 library name typo breaks discovery

Medium Severity

The SDL2 library name list contains SDL2-2.0 but the FreeBSD ports system uses SDL-2.0 (without the extra 2 before the dash). The deleted FindSDL2.cmake had the correct name with a comment explaining "SDL-2.0 is the name used by FreeBSD ports... don't confuse it for the version number." This typo will cause FreeBSD builds to fail finding SDL2.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant