Auto-supply the stored password to the terminal (no more password prompts)#25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts configured with password authentication worked fine for metrics, quick-commands, and snippets (which use the russh client and fall back to the stored password), but the interactive terminal spawns the system ssh binary, which can't read the stored password and prompted for it on every connection.
This wires the stored password into the terminal's ssh child through
SSH_ASKPASS:SSH_ASKPASSat the omny binary itself and setsSSH_ASKPASS_REQUIRE=force, passing the password via the child's environment (OMNY_ASKPASS_PASSWORD).Security: The password is only ever passed through the child process environment (it already lives in plaintext in
hosts.toml). It is never written to disk, never on the command line / ps, and never sent to the remote. The askpass helper answers genuine password prompts only; it never feeds the password to a host-key yes/no confirmation. Requires OpenSSH 8.4+ (modern macOS/Linux/Termux); ifcurrent_exeis unavailable it falls back to the old interactive prompt.Covered by 4 tests for the prompt-discrimination logic.