Chore/remove dead code#31
Merged
Merged
Conversation
Drop Screen::title, Host::id, key_path_for_host, the superseded host_list render path, and the unused popup renderers.
Drop FileManagerPanel::clamp_scroll, ProbeOutput::section_names, and KeySetupMachine::password_disabled along with the tests that were their only callers. Empty-parse assertions now check the sections field directly; password-state assertions read the field directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed dead code with no effect on runtime behaviour: unused functions with no callers (
Screen::title,Host::id,key_path_for_host, the supersededhost_listrender path, and two unused popup renderers), plus three methods that were only reachable from their own tests (FileManagerPanel::clamp_scroll,ProbeOutput::section_names,KeySetupMachine::password_disabled) and those tests.