Skip to content

Fix bug when loading 2d timeseries #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cody-G wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug when loading 2d timeseries #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/ImagineFormat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ function load(io::Stream{format"Imagine"}; mode="r")
pstart = h["piezo"]["stop position"]
pstop = h["piezo"]["start position"]
if length(sz)>2
dz = abs(pstart - pstop)/(sz[3]-1)
else dz = 0.0 end
#Setting dz to something > 0.0 prevents an error when creating an AxisArray with a zero step
dz = (pstart == pstop) ? 1.0 : abs(pstart - pstop)/(sz[3]-1)
Copy link
Copy Markdown
Owner

@timholy timholy Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I failed to notice this.

Should we also check that sz[3] == 1? In such cases would it be better to return a space × space × time array?

Copy link
Copy Markdown
Owner

@timholy timholy Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see fcda3d2

end

axisnames = havez ? (:x, :l, :z) : (:x, :l)
pixelspacing = havez ? (um_per_pixel, um_per_pixel, dz) : (um_per_pixel, um_per_pixel)
Expand Down