Skip to content

Fix failing regression-tests CI job: mise shim argv[0] and webapp x position - #280

Merged
timmo001 merged 2 commits into
distro/arch-omarchy-quattrofrom
copilot/fix-regression-tests-job
Aug 14, 2026
Merged

Fix failing regression-tests CI job: mise shim argv[0] and webapp x position#280
timmo001 merged 2 commits into
distro/arch-omarchy-quattrofrom
copilot/fix-regression-tests-job

Conversation

Copilot AI commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Two test bugs introduced in recent commits caused the regression-tests job to fail.

tests/scripts/mise.test.sh — shim argv[0] assertion

The test for exec -a argv[0] preservation used perl -e 'print $0', but Perl always sets $0 to "-e" for inline scripts regardless of the actual argv[0]. Since Perl is a native ELF binary, exec -a name perl script.pl correctly propagates argv[0] at the OS level — it just can't be observed via $0 in -e mode.

Fix: replace the inline script with a Perl script file that reads /proc/$$/cmdline to get the real argv[0]:

# Before (always outputs "-e")
shim_output=$(PATH="$binary_bin:/usr/bin" "$shim" -e 'print $0')

# After (reads true argv[0] from the process cmdline)
cat >"$perl_script" <<'PERL'
open(my $fh, '<', "/proc/$$/cmdline") or die $!;
local $/; my $data = <$fh>; close $fh;
my @args = split /\0/, $data;
print $args[0], "\n";
PERL
shim_output=$(PATH="$binary_bin:/usr/bin" "$shim" "$perl_script")

tests/scripts/launch-floating-webapp.test.sh — wrong expected x position

The expected x coordinate was 1520 but the script correctly computes 1514:

1920 (monitor_width) − 10 (reserved_right) − 380 (WIDTH) − 16 (RIGHT_MARGIN) = 1514

Fix: update the assertion from x = 1520 to x = 1514.

…position

Co-authored-by: timmo001 <28114703+timmo001@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job regression-tests Fix failing regression-tests CI job: mise shim argv[0] and webapp x position Aug 14, 2026
Copilot AI requested a review from timmo001 August 14, 2026 13:46
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
dotfiles-docs fcb4281 Commit Preview URL

Branch Preview URL
Aug 14 2026, 01:46 PM

@timmo001
timmo001 marked this pull request as ready for review August 14, 2026 13:56
@timmo001
timmo001 enabled auto-merge (squash) August 14, 2026 14:00
@timmo001
timmo001 merged commit b6efff1 into distro/arch-omarchy-quattro Aug 14, 2026
17 checks passed
@timmo001
timmo001 deleted the copilot/fix-regression-tests-job branch August 14, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants