Fix default OpenAI model unit test#678
Closed
timrogers wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gpt-5.4-minibut the unit test still asserted the oldgpt-4o, causing test failures.Description
default_openai_model_is_gpt_5_4_miniand update its assertion toassert_eq!(OPENAI_MODEL, "gpt-5.4-mini");insrc/llm.rs.Testing
rustup run 1.94.0 cargo test --locked --all-features default_openai_model_is_gpt_5_4_mini(withCOPILOT_SKIP_CLI_DOWNLOAD=1) which passed, and verified the full test suite withNO_PROXY=localhost,127.0.0.1,::1 COPILOT_SKIP_CLI_DOWNLOAD=1 rustup run 1.94.0 cargo test --locked --all-featureswhich passed (59 passed; 0 failed), and confirmedNO_PROXY=localhost,127.0.0.1,::1 COPILOT_SKIP_CLI_DOWNLOAD=1 rustup run 1.94.0 cargo build --release --lockedsucceeded.Codex Task