⚡ Bolt: Optimize DocxXMLEditor change ID generation#9
Conversation
- Implemented caching for `_next_change_id` in `DocxXMLEditor` to avoid O(N) scan on every insertion. - Updated attribute injection to verify and respect manually assigned IDs, updating the cache if necessary. - Reduces complexity of batch tracked change insertions from O(N^2) to O(N). - Benchmark shows ~11x speedup (2.9s -> 0.26s) for 1000 insertions. Co-authored-by: timteh <211128536+timteh@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Caches the
_next_change_idinDocxXMLEditorto prevent rescanning the entire DOM for every new tracked change insertion.🎯 Why: The previous implementation scanned all
w:insandw:delelements to find the maximumw:idevery time a new change was added. This resulted in O(N^2) complexity for batch insertions (e.g., applying redlines).📊 Impact:
🔬 Measurement:
PR created automatically by Jules for task 6118911914792885974 started by @timteh