Polish TUI device list: lipgloss styling, window sizing, and view preview test - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lipgloss-based styles (appStyle,titleStyle,subtitleStyle,selectedStyle,normalStyle,emptyStyle,helpStyle) and applied them inView()to render a bordered, padded panel with styled title, subtitle, selected row, and help text.widthfield to themodeland handlebubbletea.WindowSizeMsginUpdate()to constrain panel width viaMaxWidthso the UI adapts to terminal size.View()usingstrings.Joinand styled lines; replaced the plain text layout with the styled panel.TestViewPreviewtointernal/tui/tui_test.gowhich constructs a samplemodeland asserts the rendered view contains the title and a selected device name; keptTestSelectDevicewhich will skip when no/dev/ttyis available.Testing
go test ./internal/tui -v; the newTestViewPreviewpassed and produced a textual preview of the styled TUI.TestSelectDeviceremains present and will be skipped on CI environments with no TTY (it is skipped when/dev/ttycannot be opened).Codex Task