fix: shut down child sessions before disposal#170
Open
liu-qingyuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_shutdownbefore disposing retained childAgentSessioninstancesclearCompleted(), and manager shutdownPromise.allSettled; log runner-level failures without blocking sibling or parent lifecycle cleanupProblem
runAgent()creates a standalone session and binds extensions, butAgentSession.dispose()only invalidates the extension context. It does not emitsession_shutdown. The parent manager therefore discarded retained child sessions without giving child extensions a chance to release timers, transports, or subprocesses.The unref'd manager interval described in #126 is one symptom. A child extension with a referenced MCP transport can also keep a settled headless process alive indefinitely.
Design
AgentManageralready owns child retention for resume and record eviction, so teardown stays private to that module. This mirrors the ordering used by Pi'sAgentSessionRuntime.dispose()without migrating subagents to the larger runtime/session-replacement interface.Completed sessions remain available for resume until the existing cleanup conditions remove their records. Production lifecycle handlers now await cleanup before proceeding.
Verification
npm run lintnpm run typechecknpm run test— 752 passed, 5 skippednpm run test:e2e— 47 passed, 5 skippednpm run buildagent_settled, exited naturally with code 0, and left no process after 3 secondsCloses #126